Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417183002: Support 'mlogin' screen type for multi-profile login to onFocus event to IME extensions. This is th… (Closed)

Created:
6 years, 5 months ago by Shu Chen
Modified:
6 years, 5 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support 'mlogin' screen type for multi-profile login to onFocus event to IME extensions. This is the follow up change per comment in https://codereview.chromium.org/418273002/ BUG=395621 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285594

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Shu Chen
Nikita, can you please review this cl? Thanks
6 years, 5 months ago (2014-07-25 14:04:38 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/417183002/diff/1/chrome/browser/extensions/api/input_ime/input_ime_api.cc File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right): https://codereview.chromium.org/417183002/diff/1/chrome/browser/extensions/api/input_ime/input_ime_api.cc#newcode162 chrome/browser/extensions/api/input_ime/input_ime_api.cc:162: screen_type = "mlogin"; nit: secondary-login?
6 years, 5 months ago (2014-07-25 14:28:58 UTC) #2
Shu Chen
https://codereview.chromium.org/417183002/diff/1/chrome/browser/extensions/api/input_ime/input_ime_api.cc File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right): https://codereview.chromium.org/417183002/diff/1/chrome/browser/extensions/api/input_ime/input_ime_api.cc#newcode162 chrome/browser/extensions/api/input_ime/input_ime_api.cc:162: screen_type = "mlogin"; On 2014/07/25 14:28:57, Nikita Kostylev wrote: ...
6 years, 5 months ago (2014-07-25 14:30:58 UTC) #3
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 5 months ago (2014-07-25 14:31:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/417183002/20001
6 years, 5 months ago (2014-07-25 14:31:35 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 15:42:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 285594

Powered by Google App Engine
This is Rietveld 408576698