Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 417173003: Win-Clang update script: update paths for 3.6 (Closed)

Created:
6 years, 4 months ago by hans
Modified:
6 years, 4 months ago
CC:
chromium-reviews, inferno
Project:
chromium
Visibility:
Public.

Description

Win-Clang update script: update paths for 3.6 BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287342

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/clang/scripts/update.py View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
hans
Please take a look. It's not ideal to be dependent on the version number here, ...
6 years, 4 months ago (2014-08-04 15:35:46 UTC) #1
Nico
lgtm https://codereview.chromium.org/417173003/diff/1/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): https://codereview.chromium.org/417173003/diff/1/tools/clang/scripts/update.py#newcode153 tools/clang/scripts/update.py:153: # TODO(hans): Make this (and the .gypi file) ...
6 years, 4 months ago (2014-08-04 15:48:51 UTC) #2
hans
On 2014/08/04 15:48:51, Nico (away) wrote: > https://codereview.chromium.org/417173003/diff/1/tools/clang/scripts/update.py#newcode153 > tools/clang/scripts/update.py:153: # TODO(hans): Make this (and ...
6 years, 4 months ago (2014-08-04 15:56:30 UTC) #3
hans
The CQ bit was checked by hans@chromium.org
6 years, 4 months ago (2014-08-04 15:56:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/417173003/1
6 years, 4 months ago (2014-08-04 15:57:32 UTC) #5
commit-bot: I haz the power
Change committed as 287342
6 years, 4 months ago (2014-08-04 15:58:37 UTC) #6
Timur Iskhodzhanov
FYI, this has broken down the ASan/Win LKGR bot as it uses a fixed pre-3.6 ...
6 years, 4 months ago (2014-08-05 09:52:36 UTC) #7
Timur Iskhodzhanov
https://codereview.chromium.org/443603002/
6 years, 4 months ago (2014-08-05 10:04:30 UTC) #8
hans
6 years, 4 months ago (2014-08-05 16:49:10 UTC) #9
Message was sent while issue was closed.
On 2014/08/05 09:52:36, Timur Iskhodzhanov wrote:
> FYI, this has broken down the ASan/Win LKGR bot as it uses a fixed pre-3.6
> revision
> 
>
http://build.chromium.org/p/chromium.lkgr/builders/Win%20ASan%20Release/build...

Oops, I didn't think about that. Sounds like another good reason to fix the
script/gypi file to not include the llvm version number :)

> I'm gonna bump the revision now...

Thanks!

Powered by Google App Engine
This is Rietveld 408576698