Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 417163005: Revert of Web Notifications should always reappear as popups when updated. (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
Reviewers:
Peter Beverloo, dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Web Notifications should always reappear as popups when updated. (https://codereview.chromium.org/301713002/) Reason for revert: Causes Linux ASAN errors. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/5914/steps/interactive_ui_tests/logs/TestNotificationReplacement Original issue's description: > Web Notifications should always reappear as popups when updated. > > The message center already does this for notifications with a higher > priority than the notification they replace, but this makes it explicit > for Web Notifications (which cannot indicate priority). > > This patch re-enables the NotificationTest.TestNotificationReplacement > test, which was marked as DISABLED because of LSan failures. > > BUG=366102, 366539 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286831 TBR=dewittj, peter NOTREECHECKS=true NOTRY=true BUG=366102, 366539 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -83 lines) Patch
M chrome/browser/notifications/notification_browsertest.cc View 4 chunks +11 lines, -41 lines 0 comments Download
M ui/message_center/notification_list.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/message_center/notification_list_unittest.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
erikchen
Created Revert of Web Notifications should always reappear as popups when updated.
6 years, 4 months ago (2014-07-31 19:46:16 UTC) #1
Peter Beverloo
Oh no, sorry for the trouble! lgtm (you'll still need to TBR OWNERS).
6 years, 4 months ago (2014-07-31 19:47:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/417163005/1
6 years, 4 months ago (2014-07-31 19:48:10 UTC) #3
erikchen
The CQ bit was unchecked by erikchen@chromium.org
6 years, 4 months ago (2014-07-31 19:48:48 UTC) #4
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 4 months ago (2014-07-31 19:48:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/417163005/1
6 years, 4 months ago (2014-07-31 19:52:12 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 20:01:25 UTC) #7
Message was sent while issue was closed.
Change committed as 286877

Powered by Google App Engine
This is Rietveld 408576698