chrome/common/extensions/docs/server2/mock_file_system.py - Issue 417163004: Docserver: Update Future.Then() to be more Promise-like

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/mock_file_system.py

Issue 417163004: Docserver: Update Future.Then() to be more Promise-like (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/future_test.py ('k') | chrome/common/extensions/docs/server2/mock_file_system_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/mock_file_system.py

diff --git a/chrome/common/extensions/docs/server2/mock_file_system.py b/chrome/common/extensions/docs/server2/mock_file_system.py

index e15f58c8f1c8c54df2420d78e0f563f69d730633..52a84bde7b4b54e6c88a03c39d0593dcd1d4ab56 100644

--- a/chrome/common/extensions/docs/server2/mock_file_system.py

+++ b/chrome/common/extensions/docs/server2/mock_file_system.py

@@ -42,16 +42,15 @@ class MockFileSystem(FileSystem):

from |_updates|, if any.

'''

self._read_count += 1

- future_result = self._file_system.Read(paths, skip_not_found=skip_not_found)

- def resolve():

+ def next(result):

self._read_resolve_count += 1

- result = future_result.Get()

for path in result.iterkeys():

update = self._GetMostRecentUpdate(path)

if update is not None:

result[path] = update

return result

- return Future(callback=resolve)

+ return self._file_system.Read(paths,

+ skip_not_found=skip_not_found).Then(next)

def Refresh(self):

return self._file_system.Refresh()