chrome/common/extensions/docs/server2/fake_url_fetcher.py - Issue 417163004: Docserver: Update Future.Then() to be more Promise-like

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/fake_url_fetcher.py

Issue 417163004: Docserver: Update Future.Then() to be more Promise-like (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/chroot_file_system.py ('k') | chrome/common/extensions/docs/server2/file_system.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/fake_url_fetcher.py

diff --git a/chrome/common/extensions/docs/server2/fake_url_fetcher.py b/chrome/common/extensions/docs/server2/fake_url_fetcher.py

index dbfaa5557ee4a352c6eec2bfb1a20a1495897b98..21b6cf6eb3f9a7b537ed06f95b5720d848cf7e96 100644

--- a/chrome/common/extensions/docs/server2/fake_url_fetcher.py

+++ b/chrome/common/extensions/docs/server2/fake_url_fetcher.py

@@ -129,11 +129,10 @@ class MockURLFetcher(object):

def FetchAsync(self, url, **kwargs):

self._fetch_async_count += 1

- future = self._fetcher.FetchAsync(url, **kwargs)

- def resolve():

+ def next(result):

self._fetch_resolve_count += 1

- return future.Get()

- return Future(callback=resolve)

+ return result

+ return self._fetcher.FetchAsync(url, **kwargs).Then(next)

def CheckAndReset(self,

fetch_count=0,