Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 417123006: Make webkit-patch auto-rebaseline a bit more robust to errors. (Closed)

Created:
6 years, 5 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
eseidel, Xianzhu, ojan
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Make webkit-patch auto-rebaseline a bit more robust to errors. This logs errors when the underlying commands fail, and tries to recover a bit more cleanly. TBR=eseidel@chromium.org, ojan@chromium.org, wangxianzhu@chromium.org BUG=397678 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179877

Patch Set 1 #

Patch Set 2 : update test result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 2 chunks +5 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Dirk Pranke
6 years, 5 months ago (2014-07-25 21:34:43 UTC) #1
Xianzhu
lgtm.
6 years, 5 months ago (2014-07-25 22:10:45 UTC) #2
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-07-29 18:23:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/417123006/1
6 years, 4 months ago (2014-07-29 18:24:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 20:00:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 20:07:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/18142) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/17581)
6 years, 4 months ago (2014-07-29 20:07:35 UTC) #7
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-08-08 20:58:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/417123006/1
6 years, 4 months ago (2014-08-08 20:59:59 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-08 21:08:51 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 21:15:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19090)
6 years, 4 months ago (2014-08-08 21:15:18 UTC) #12
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-08-08 21:51:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/417123006/20001
6 years, 4 months ago (2014-08-08 21:52:03 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 23:28:02 UTC) #15
Message was sent while issue was closed.
Change committed as 179877

Powered by Google App Engine
This is Rietveld 408576698