Issue 417123002: Clear current target in TimelineModelImpl only when recording has stopped

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 417123002: Clear current target in TimelineModelImpl only when recording has stopped (Closed)

Created:
6 years, 5 months ago by yurys

Modified:
6 years, 5 months ago

Reviewers:
sergeyv, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Clear current target in TimelineModelImpl only when recording has stopped reset can be called when clearing records in Timeline that is being recorded. After such action recording continues and current Target doesn't change. BUG=397216 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178907

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/devtools/front_end/timeline/TimelineModelImpl.js	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/417123002/1

6 years, 5 months ago (2014-07-25 08:01:56 UTC) #4

yurys

6 years, 5 months ago (2014-07-25 08:04:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r178907 (presubmit successful).

Expand Messages | Collapse Messages