Cast highestEnclosingNodeOfType() return value to tighter type

Cast highestEnclosingNodeOfType() return value to tighter type

Cast highestEnclosingNodeOfType() return value to tighter type to increase
code readability. This CL also renames the type checking functions passed
to highestEnclosingNodeOfType() to make it clear what type of Node/Element
is returned.

R=leviw@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179093

[leviw_travelin_and_unemployed, 2014-07-28 21:24:45]

LGTM.

[commit-bot: I haz the power, 2014-07-28 21:25:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/417113011/1

[commit-bot: I haz the power, 2014-07-28 21:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-28 21:25:27]

Failed to apply patch for Source/core/editing/BreakBlockquoteCommand.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/BreakBlockquoteCommand.cpp
  Hunk #1 succeeded at 33 with fuzz 2 (offset 1 line).
  Hunk #2 succeeded at 69 with fuzz 1 (offset 1 line).
  Hunk #3 succeeded at 102 (offset 1 line).
  Hunk #4 FAILED at 134.
  1 out of 4 hunks FAILED -- saving rejects to file
Source/core/editing/BreakBlockquoteCommand.cpp.rej

Patch:       Source/core/editing/BreakBlockquoteCommand.cpp
Index: Source/core/editing/BreakBlockquoteCommand.cpp
diff --git a/Source/core/editing/BreakBlockquoteCommand.cpp
b/Source/core/editing/BreakBlockquoteCommand.cpp
index
a3fb03687485fa8cebe6bd2ea81f4e47a8288844..31c6ac2b3ec1af03802a4a132ce01a51558ad194
100644
--- a/Source/core/editing/BreakBlockquoteCommand.cpp
+++ b/Source/core/editing/BreakBlockquoteCommand.cpp
@@ -32,6 +32,7 @@
 #include "core/editing/VisiblePosition.h"
 #include "core/editing/htmlediting.h"
 #include "core/html/HTMLElement.h"
+#include "core/html/HTMLQuoteElement.h"
 #include "core/rendering/RenderListItem.h"
 
 namespace blink {
@@ -67,8 +68,8 @@ void BreakBlockquoteCommand::doApply()
     Position pos = endingSelection().start().downstream();
 
     // Find the top-most blockquote from the start.
-    Node* topBlockquote = highestEnclosingNodeOfType(pos, isMailBlockquote);
-    if (!topBlockquote || !topBlockquote->parentNode() ||
!topBlockquote->isElementNode())
+    HTMLQuoteElement* topBlockquote =
toHTMLQuoteElement(highestEnclosingNodeOfType(pos,
isMailHTMLBlockquoteElement));
+    if (!topBlockquote || !topBlockquote->parentNode())
         return;
 
     RefPtrWillBeRawPtr<Element> breakNode = createBreakElement(document());
@@ -100,7 +101,7 @@ void BreakBlockquoteCommand::doApply()
         pos = pos.next();
 
     // Adjust the position so we don't split at the beginning of a quote.
-    while (isFirstVisiblePositionInNode(VisiblePosition(pos),
enclosingNodeOfType(pos, isMailBlockquote)))
+    while (isFirstVisiblePositionInNode(VisiblePosition(pos),
enclosingNodeOfType(pos, isMailHTMLBlockquoteElement)))
         pos = pos.previous();
 
     // startNode is the first node that we need to move to the new blockquote.
@@ -133,7 +134,7 @@ void BreakBlockquoteCommand::doApply()
         ancestors.append(node);
 
     // Insert a clone of the top blockquote after the break.
-    RefPtrWillBeRawPtr<Element> clonedBlockquote =
toElement(topBlockquote)->cloneElementWithoutChildren();
+    RefPtrWillBeRawPtr<Element> clonedBlockquote =
topBlockquote->cloneElementWithoutChildren();
     insertNodeAfter(clonedBlockquote.get(), breakNode.get());
 
     // Clone startNode's ancestors into the cloned blockquote.

[Inactive, 2014-07-28 23:14:26]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-28 23:15:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/417113011/20001

[commit-bot: I haz the power, 2014-07-29 01:07:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19331)

[commit-bot: I haz the power, 2014-07-29 01:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 01:11:23]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19352)

[Inactive, 2014-07-29 01:34:31]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-29 01:35:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/417113011/40001

[commit-bot: I haz the power, 2014-07-29 03:07:05]

Change committed as 179093