Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: mojo/system/dispatcher_unittest.cc

Issue 417113010: Convert ReadData...() to use the new user pointer handling (see r285350). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « mojo/system/dispatcher.cc ('k') | mojo/system/local_data_pipe.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/system/dispatcher.h" 5 #include "mojo/system/dispatcher.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "base/synchronization/waitable_event.h" 10 #include "base/synchronization/waitable_event.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 d->ReadMessage(NullUserPointer(), NullUserPointer(), NULL, NULL, 52 d->ReadMessage(NullUserPointer(), NullUserPointer(), NULL, NULL,
53 MOJO_WRITE_MESSAGE_FLAG_NONE)); 53 MOJO_WRITE_MESSAGE_FLAG_NONE));
54 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 54 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
55 d->WriteData(NULL, NULL, MOJO_WRITE_DATA_FLAG_NONE)); 55 d->WriteData(NULL, NULL, MOJO_WRITE_DATA_FLAG_NONE));
56 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 56 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
57 d->BeginWriteData(NullUserPointer(), NullUserPointer(), 57 d->BeginWriteData(NullUserPointer(), NullUserPointer(),
58 MOJO_WRITE_DATA_FLAG_NONE)); 58 MOJO_WRITE_DATA_FLAG_NONE));
59 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 59 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
60 d->EndWriteData(0)); 60 d->EndWriteData(0));
61 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 61 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
62 d->ReadData(NULL, NULL, MOJO_READ_DATA_FLAG_NONE)); 62 d->ReadData(NullUserPointer(), NullUserPointer(),
63 MOJO_READ_DATA_FLAG_NONE));
63 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 64 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
64 d->BeginReadData(NullUserPointer(), NullUserPointer(), 65 d->BeginReadData(NullUserPointer(), NullUserPointer(),
65 MOJO_READ_DATA_FLAG_NONE)); 66 MOJO_READ_DATA_FLAG_NONE));
66 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 67 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
67 d->EndReadData(0)); 68 d->EndReadData(0));
68 Waiter w; 69 Waiter w;
69 w.Init(); 70 w.Init();
70 EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION, 71 EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION,
71 d->AddWaiter(&w, ~MOJO_HANDLE_SIGNAL_NONE, 0)); 72 d->AddWaiter(&w, ~MOJO_HANDLE_SIGNAL_NONE, 0));
72 // Okay to remove even if it wasn't added (or was already removed). 73 // Okay to remove even if it wasn't added (or was already removed).
73 d->RemoveWaiter(&w); 74 d->RemoveWaiter(&w);
74 d->RemoveWaiter(&w); 75 d->RemoveWaiter(&w);
75 76
76 EXPECT_EQ(MOJO_RESULT_OK, d->Close()); 77 EXPECT_EQ(MOJO_RESULT_OK, d->Close());
77 78
78 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 79 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
79 d->WriteMessage(NullUserPointer(), 0, NULL, 80 d->WriteMessage(NullUserPointer(), 0, NULL,
80 MOJO_WRITE_MESSAGE_FLAG_NONE)); 81 MOJO_WRITE_MESSAGE_FLAG_NONE));
81 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 82 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
82 d->ReadMessage(NullUserPointer(), NullUserPointer(), NULL, NULL, 83 d->ReadMessage(NullUserPointer(), NullUserPointer(), NULL, NULL,
83 MOJO_WRITE_MESSAGE_FLAG_NONE)); 84 MOJO_WRITE_MESSAGE_FLAG_NONE));
84 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 85 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
85 d->WriteData(NULL, NULL, MOJO_WRITE_DATA_FLAG_NONE)); 86 d->WriteData(NULL, NULL, MOJO_WRITE_DATA_FLAG_NONE));
86 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 87 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
87 d->BeginWriteData(NullUserPointer(), NullUserPointer(), 88 d->BeginWriteData(NullUserPointer(), NullUserPointer(),
88 MOJO_WRITE_DATA_FLAG_NONE)); 89 MOJO_WRITE_DATA_FLAG_NONE));
89 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 90 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
90 d->EndWriteData(0)); 91 d->EndWriteData(0));
91 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 92 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
92 d->ReadData(NULL, NULL, MOJO_READ_DATA_FLAG_NONE)); 93 d->ReadData(NullUserPointer(), NullUserPointer(),
94 MOJO_READ_DATA_FLAG_NONE));
93 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 95 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
94 d->BeginReadData(NullUserPointer(), NullUserPointer(), 96 d->BeginReadData(NullUserPointer(), NullUserPointer(),
95 MOJO_READ_DATA_FLAG_NONE)); 97 MOJO_READ_DATA_FLAG_NONE));
96 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 98 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
97 d->EndReadData(0)); 99 d->EndReadData(0));
98 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 100 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
99 d->AddWaiter(&w, ~MOJO_HANDLE_SIGNAL_NONE, 0)); 101 d->AddWaiter(&w, ~MOJO_HANDLE_SIGNAL_NONE, 0));
100 d->RemoveWaiter(&w); 102 d->RemoveWaiter(&w);
101 } 103 }
102 104
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 dispatcher_->BeginWriteData(NullUserPointer(), 170 dispatcher_->BeginWriteData(NullUserPointer(),
169 NullUserPointer(), 171 NullUserPointer(),
170 MOJO_WRITE_DATA_FLAG_NONE)); 172 MOJO_WRITE_DATA_FLAG_NONE));
171 break; 173 break;
172 case END_WRITE_DATA: 174 case END_WRITE_DATA:
173 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 175 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
174 dispatcher_->EndWriteData(0)); 176 dispatcher_->EndWriteData(0));
175 break; 177 break;
176 case READ_DATA: 178 case READ_DATA:
177 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 179 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
178 dispatcher_->ReadData(NULL, NULL, MOJO_READ_DATA_FLAG_NONE)); 180 dispatcher_->ReadData(NullUserPointer(), NullUserPointer(),
181 MOJO_READ_DATA_FLAG_NONE));
179 break; 182 break;
180 case BEGIN_READ_DATA: 183 case BEGIN_READ_DATA:
181 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 184 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
182 dispatcher_->BeginReadData(NullUserPointer(), 185 dispatcher_->BeginReadData(NullUserPointer(),
183 NullUserPointer(), 186 NullUserPointer(),
184 MOJO_READ_DATA_FLAG_NONE)); 187 MOJO_READ_DATA_FLAG_NONE));
185 break; 188 break;
186 case END_READ_DATA: 189 case END_READ_DATA:
187 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 190 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
188 dispatcher_->EndReadData(0)); 191 dispatcher_->EndReadData(0));
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 event.Signal(); // Kicks off real work on the threads. 278 event.Signal(); // Kicks off real work on the threads.
276 } // Joins all the threads. 279 } // Joins all the threads.
277 280
278 EXPECT_EQ(MOJO_RESULT_OK, d->Close()); 281 EXPECT_EQ(MOJO_RESULT_OK, d->Close());
279 } 282 }
280 } 283 }
281 284
282 } // namespace 285 } // namespace
283 } // namespace system 286 } // namespace system
284 } // namespace mojo 287 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/system/dispatcher.cc ('k') | mojo/system/local_data_pipe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698