Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 417113009: Avoid infinite recursion with identity variables.

Created:
6 years, 5 months ago by deymo
Modified:
6 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Avoid infinite recursion with identity variables. Some generators like gypd and gypsh define the generator_default_variables as an identity expansion. For example, the variable 'INTERMEDIATE_DIR' would expand to '<(INTERMEDIATE_DIR)' which lends to an infinite recursion if a .gyp file uses any of those variables. This patch detects trivial infinite recursive variable expansions like this one and leaves them that way. BUG=gyp:141 TEST=`gyp --debug=variables --format=gypd test.gyp` shows avoiding infinite recursion message when test.gyp has an INTERMEDIATE_DIR variable expansion.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M pylib/gyp/input.py View 1 chunk +22 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
deymo
Hi mark, please take a look at this patch. I'm hitting this problem with any ...
6 years, 5 months ago (2014-07-25 20:57:39 UTC) #1
Mark Mentovai
LGTM
6 years, 4 months ago (2014-07-29 13:16:31 UTC) #2
deymo
The CQ bit was checked by deymo@chromium.org
6 years, 4 months ago (2014-07-29 14:16:10 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 14:17:34 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 4 months ago (2014-07-29 14:17:34 UTC) #5
deymo
mark, can you submit this?
6 years, 4 months ago (2014-07-29 14:18:49 UTC) #6
Mark Mentovai
6 years, 4 months ago (2014-07-29 15:13:40 UTC) #7
Committed r1958.

Powered by Google App Engine
This is Rietveld 408576698