Issue 417113005: Blink roll 178929:178934

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 417113005: Blink roll 178929:178934 (Closed)

Created:
6 years, 4 months ago by blink-deps-roller

Modified:
6 years, 4 months ago

Reviewers:
haraken, Julien - ping for review

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Blink roll 178929:178934 http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178934&mode=html TBR=haraken@chromium.org,jchaffraix@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285602

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

blink-deps-roller

The CQ bit was checked by blink-deps-roller@chromium.org

6 years, 4 months ago (2014-07-25 15:08:25 UTC) #2

blink-deps-roller

This roll was created by the Blink AutoRollBot. http://www.chromium.org/blink/blinkrollbot

6 years, 4 months ago (2014-07-25 15:08:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blink-deps-roller@chromium.org/417113005/1

6 years, 4 months ago (2014-07-25 15:08:58 UTC) #4

dmichael (off chromium)

6 years, 4 months ago (2014-07-25 18:37:49 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/414223006/ by dmichael@chromium.org.

The reason for reverting is: Seems to have broken browser_tests:
DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch (run #4):
[ RUN      ] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch
HTTP server started on http://127.0.0.1:52329...
sending server_data: {"host": "127.0.0.1", "port": 52329} (36 bytes)
../../chrome/browser/devtools/devtools_sanity_browsertest.cc:104: Failure
Value of: result
  Actual: "[FAILED] TypeError: Cannot read property 'sourcesView' of undefined"
Expected: "[OK]".

Expand Messages | Collapse Messages