Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 417113002: round and bevel hairline rects show the same as miter hairline rects (Closed)

Created:
6 years, 5 months ago by yunchao
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

round and bevel hairline rects show the same as miter hairline rects So round and bevel hairline rects can generate the vertices and indices the same as miter rects do. The original code behaves the same as bevel rects for round and bevel hairline rects. This small CL can save (vertices and indices) buffer memory as well as improve performance (draw less triangles). gm cases show no difference after this CL is applied. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2bff230d835fbc84f0ce8b2e7a399fe8416ec7c8

Patch Set 1 : #

Total comments: 1

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/gpu/GrAARectRenderer.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yunchao
PTAL, thanks.
6 years, 5 months ago (2014-07-25 08:12:39 UTC) #1
robertphillips
lgtm + comment suggestion https://codereview.chromium.org/417113002/diff/20001/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/417113002/diff/20001/src/gpu/GrAARectRenderer.cpp#newcode765 src/gpu/GrAARectRenderer.cpp:765: bool miterStroke = true; I ...
6 years, 4 months ago (2014-07-28 19:31:30 UTC) #2
yunchao
The CQ bit was checked by yunchao.he@intel.com
6 years, 4 months ago (2014-07-29 02:07:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/417113002/40001
6 years, 4 months ago (2014-07-29 02:07:59 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 02:18:55 UTC) #5
Message was sent while issue was closed.
Change committed as 2bff230d835fbc84f0ce8b2e7a399fe8416ec7c8

Powered by Google App Engine
This is Rietveld 408576698