Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417103002: Deprecate openDatabase and openDatabaseSync in workers. (Closed)

Created:
6 years, 5 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
michaeln
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Deprecate openDatabase and openDatabaseSync in workers. We show console message when they are used. Intent to deprecate: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2SWnbXAL7Wg BUG=397429 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178954

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M LayoutTests/fast/workers/storage/change-version-handle-reuse-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/change-version-handle-reuse-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/change-version-sync-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/empty-statement-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/execute-sql-args-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/execute-sql-args-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/interrupt-database-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/multiple-databases-garbage-collection-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/multiple-transactions-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/multiple-transactions-on-different-handles-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/multiple-transactions-on-different-handles-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/open-database-creation-callback-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/open-database-empty-version-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/open-database-inputs-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/open-database-set-empty-version-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/open-database-while-transaction-in-progress-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/open-database-while-transaction-in-progress-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/read-and-write-transactions-dont-run-together-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/sql-data-types-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/sql-exception-codes-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/test-authorizer-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/transaction-in-transaction-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-origin-worker-websql-allowed-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/workers/terminate-during-sync-operation-websql-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/android/fast/workers/storage/test-authorizer-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/workers/storage/test-authorizer-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/workers/storage/test-authorizer-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/workers/storage/test-authorizer-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/workers/storage/test-authorizer-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/workers/storage/test-authorizer-sync-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Please review this.
6 years, 5 months ago (2014-07-25 09:10:02 UTC) #1
michaeln
lgtm++
6 years, 4 months ago (2014-07-25 20:20:58 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-07-25 20:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/417103002/20001
6 years, 4 months ago (2014-07-25 20:24:24 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-25 20:28:01 UTC) #5
Message was sent while issue was closed. 
Change committed as 178954

Powered by Google App Engine
This is Rietveld 408576698