Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 417093006: Have Node::enclosingLinkEventParentOrSelf() return an Element (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, zoltan1
Project:
blink
Visibility:
Public.

Description

Have Node::enclosingLinkEventParentOrSelf() return an Element Have Node::enclosingLinkEventParentOrSelf() return an Element so that the caller does not have to do an unsafe-looking toElement() cast. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179281

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M Source/core/dom/Node.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +6 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Inactive
6 years, 4 months ago (2014-07-30 23:53:35 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-07-30 23:57:14 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-30 23:59:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/417093006/1
6 years, 4 months ago (2014-07-30 23:59:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-31 01:12:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 01:14:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/18744)
6 years, 4 months ago (2014-07-31 01:14:54 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-31 01:48:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/417093006/20001
6 years, 4 months ago (2014-07-31 01:48:44 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-31 02:53:27 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 03:19:12 UTC) #11
Message was sent while issue was closed.
Change committed as 179281

Powered by Google App Engine
This is Rietveld 408576698