Separate Toolkit specific impl

chrome/browser/renderer_context_menu/render_view_context_menu.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_
 #define CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_
 
 #include <map>
 #include <string>
 
@@ skipping 31 matching lines @@
 }
 
 namespace blink {
 struct WebMediaPlayerAction;
 struct WebPluginAction;
 }
 
 class RenderViewContextMenu : public ui::SimpleMenuModel::Delegate,
                               public RenderViewContextMenuProxy {
  public:
+  // A delegate interface to communicate with the toolkit used by
+  // the embedder.
+  class ToolkitDelegate {
+   public:
+    virtual ~ToolkitDelegate() {}
+    // Initialize the toolkit's menu.
+    virtual void Init(ui::SimpleMenuModel* menu_model) = 0;
+
+    virtual void Cancel() = 0;
+
+    // Updates the actual menu items controlled by the toolkit.
+    virtual void UpdateMenuItem(int command_id,
+                                bool enabled,
+                                bool hidden,
+                                const base::string16& title) = 0;
+  };
+
   static const size_t kMaxSelectionTextLength;
 
   // Convert a command ID so that it fits within the range for
   // content context menu.
   static int ConvertToContentCustomCommandId(int id);
 
   // True if the given id is the one generated for content context menu.
   static bool IsContentCustomCommandId(int id);
 
   RenderViewContextMenu(content::RenderFrameHost* render_frame_host,
@@ skipping 10 matching lines @@
   const ui::SimpleMenuModel& menu_model() const { return menu_model_; }
   const content::ContextMenuParams& params() const { return params_; }
 
   // SimpleMenuModel::Delegate implementation.
   virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
   virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
   virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE;
   virtual void MenuWillShow(ui::SimpleMenuModel* source) OVERRIDE;
   virtual void MenuClosed(ui::SimpleMenuModel* source) OVERRIDE;
 
-  // RenderViewContextMenuProxy implementation.
+  // RenderViewContextMenuProxy implementation.em

[sky, 2014/07/31 21:23:43]

nit: remove em

[oshima, 2014/07/31 22:02:15]

Done.

   virtual void AddMenuItem(int command_id,
                            const base::string16& title) OVERRIDE;
   virtual void AddCheckItem(int command_id,
                             const base::string16& title) OVERRIDE;
   virtual void AddSeparator() OVERRIDE;
   virtual void AddSubMenu(int command_id,
                           const base::string16& label,
                           ui::MenuModel* model) OVERRIDE;
   virtual void UpdateMenuItem(int command_id,
                               bool enabled,
                               bool hidden,
                               const base::string16& title) OVERRIDE;
   virtual content::RenderViewHost* GetRenderViewHost() const OVERRIDE;
   virtual content::WebContents* GetWebContents() const OVERRIDE;
   virtual content::BrowserContext* GetBrowserContext() const OVERRIDE;
 
  protected:
+  void set_toolkit_delegate(scoped_ptr<ToolkitDelegate> delegate) {
+    toolkit_delegate_ = delegate.Pass();
+  }
+
+  ToolkitDelegate* toolkit_delegate() {
+    return toolkit_delegate_.get();
+  }
+
   void InitMenu();
   Profile* GetProfile();
 
   // Platform specific functions.
-  virtual void PlatformInit() = 0;
-  virtual void PlatformCancel() = 0;
   virtual bool GetAcceleratorForCommandId(
       int command_id,
       ui::Accelerator* accelerator) = 0;
   virtual void AppendPlatformEditableItems();
 
   content::ContextMenuParams params_;
   content::WebContents* source_web_contents_;
   // The RenderFrameHost's IDs.
   int render_process_id_;
   int render_frame_id_;
@@ skipping 94 matching lines @@
 
   // Our observers.
   mutable ObserverList<RenderViewContextMenuObserver> observers_;
 
   // Whether a command has been executed. Used to track whether menu observers
   // should be notified of menu closing without execution.
   bool command_executed_;
 
   scoped_ptr<ContextMenuContentType> content_type_;
 
+  scoped_ptr<ToolkitDelegate> toolkit_delegate_;
+
   DISALLOW_COPY_AND_ASSIGN(RenderViewContextMenu);
 };
 
 #endif  // CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_