Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 417043008: Bring back Gaia avatars if --new-avatar-menu is turned on. (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Bring back Gaia avatars if --new-avatar-menu is turned on. This should work whether or not --google-profile-info is turned on. BUG=399678 TEST=Flip --new-avatar-menu (but not --google-profile-info). You should be able to choose your Gaia avatar from the manageProfile dialog. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287423

Patch Set 1 #

Total comments: 2

Patch Set 2 : commas need spaces too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/signin/core/common/profile_management_switches.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
noms (inactive)
6 years, 4 months ago (2014-08-01 22:39:42 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/417043008/diff/1/components/signin/core/common/profile_management_switches.cc File components/signin/core/common/profile_management_switches.cc (right): https://codereview.chromium.org/417043008/diff/1/components/signin/core/common/profile_management_switches.cc#newcode126 components/signin/core/common/profile_management_switches.cc:126: CheckFlag(switches::kGoogleProfileInfo,STATE_NONE); nit: space after ,
6 years, 4 months ago (2014-08-04 15:31:25 UTC) #2
noms (inactive)
https://codereview.chromium.org/417043008/diff/1/components/signin/core/common/profile_management_switches.cc File components/signin/core/common/profile_management_switches.cc (right): https://codereview.chromium.org/417043008/diff/1/components/signin/core/common/profile_management_switches.cc#newcode126 components/signin/core/common/profile_management_switches.cc:126: CheckFlag(switches::kGoogleProfileInfo,STATE_NONE); On 2014/08/04 15:31:25, Roger Tawa wrote: > nit: ...
6 years, 4 months ago (2014-08-04 17:27:43 UTC) #3
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-04 17:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/417043008/20001
6 years, 4 months ago (2014-08-04 17:29:35 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:49:30 UTC) #6
Message was sent while issue was closed.
Change committed as 287423

Powered by Google App Engine
This is Rietveld 408576698