content/browser/service_worker/service_worker_registration.h - Issue 417043006: ServiceWorker: Make SWProviderHost listen to SWRegistration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.h

Issue 417043006: ServiceWorker: Make SWProviderHost listen to SWRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address michael's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_registration.h

diff --git a/content/browser/service_worker/service_worker_registration.h b/content/browser/service_worker/service_worker_registration.h

index 41092889e74c4396711d5d829d02a63bbfbf0645..e8e65b37b8860a09cbb34e55168e7ffca12361d6 100644

--- a/content/browser/service_worker/service_worker_registration.h

+++ b/content/browser/service_worker/service_worker_registration.h

@@ -36,7 +36,9 @@ class CONTENT_EXPORT ServiceWorkerRegistration

virtual void OnVersionAttributesChanged(

ServiceWorkerRegistration* registration,

ChangedVersionAttributesMask changed_mask,

- const ServiceWorkerRegistrationInfo& info) = 0;

+ const ServiceWorkerRegistrationInfo& info) = 0;

+ virtual void OnRegistrationFailed(

+ ServiceWorkerRegistration* registration) = 0;

};

ServiceWorkerRegistration(const GURL& pattern,

@@ -62,6 +64,7 @@ class CONTENT_EXPORT ServiceWorkerRegistration

void AddListener(Listener* listener);

void RemoveListener(Listener* listener);

+ void NotifyRegistrationFailed();

ServiceWorkerRegistrationInfo GetInfo();