Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 417043006: ServiceWorker: Make SWProviderHost listen to SWRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address michael's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration.cc
diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc
index 9cd539d42567ca84cdd523fe209973bd1cd293e3..02254938d92287f75c463310f669d2a4f1acf5cb 100644
--- a/content/browser/service_worker/service_worker_registration.cc
+++ b/content/browser/service_worker/service_worker_registration.cc
@@ -40,6 +40,7 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(
ServiceWorkerRegistration::~ServiceWorkerRegistration() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK(!listeners_.might_have_observers());
if (context_)
context_->RemoveLiveRegistration(registration_id_);
ResetShouldActivateWhenReady();
@@ -53,6 +54,10 @@ void ServiceWorkerRegistration::RemoveListener(Listener* listener) {
listeners_.RemoveObserver(listener);
}
+void ServiceWorkerRegistration::NotifyRegistrationFailed() {
+ FOR_EACH_OBSERVER(Listener, listeners_, OnRegistrationFailed(this));
+}
+
ServiceWorkerRegistrationInfo ServiceWorkerRegistration::GetInfo() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
return ServiceWorkerRegistrationInfo(
@@ -175,11 +180,7 @@ void ServiceWorkerRegistration::ActivateWaitingVersion() {
// "5. Set serviceWorkerRegistration.activeWorker to activatingWorker."
// "6. Set serviceWorkerRegistration.waitingWorker to null."
- ServiceWorkerRegisterJob::DisassociateVersionFromDocuments(
- context_, activating_version);
SetActiveVersion(activating_version);
- ServiceWorkerRegisterJob::AssociateActiveVersionToDocuments(
- context_, activating_version);
// "7. Run the [[UpdateState]] algorithm passing registration.activeWorker and
// "activating" as arguments."
@@ -202,8 +203,6 @@ void ServiceWorkerRegistration::OnActivateEventFinished(
// unexpectedly terminated) we may want to retry sending the event again.
if (status != SERVICE_WORKER_OK) {
// "11. If activateFailed is true, then:..."
- ServiceWorkerRegisterJob::DisassociateVersionFromDocuments(
- context_, activating_version);
UnsetVersion(activating_version);
activating_version->Doom();
if (!waiting_version()) {

Powered by Google App Engine
This is Rietveld 408576698