Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 417043006: ServiceWorker: Make SWProviderHost listen to SWRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address michael's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration_unittest.cc
diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc
index 55d8a31842aaa0ed027637a1fdcfe71d246bd688..9457d0fd3907beeb151d93fd47a03f7424ce50af 100644
--- a/content/browser/service_worker/service_worker_registration_unittest.cc
+++ b/content/browser/service_worker/service_worker_registration_unittest.cc
@@ -40,7 +40,10 @@ class ServiceWorkerRegistrationTest : public testing::Test {
class RegistrationListener : public ServiceWorkerRegistration::Listener {
public:
RegistrationListener() {}
- ~RegistrationListener() {}
+ ~RegistrationListener() {
+ if (observed_registration_)
+ observed_registration_->RemoveListener(this);
+ }
virtual void OnVersionAttributesChanged(
ServiceWorkerRegistration* registration,
@@ -51,6 +54,12 @@ class ServiceWorkerRegistrationTest : public testing::Test {
observed_info_ = info;
}
+ virtual void OnRegistrationDeleted(
+ ServiceWorkerRegistration* registration) OVERRIDE {
+ observed_registration_->RemoveListener(this);
+ Reset();
+ }
+
void Reset() {
observed_registration_ = NULL;
observed_changed_mask_ = ChangedVersionAttributesMask();

Powered by Google App Engine
This is Rietveld 408576698