ServiceWorker: Make SWProviderHost listen to SWRegistration

content/browser/service_worker/service_worker_provider_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_provider_host.h"
 
 #include "base/stl_util.h"
 #include "content/browser/message_port_message_filter.h"
 #include "content/browser/service_worker/service_worker_context_core.h"
 #include "content/browser/service_worker/service_worker_context_request_handler.h"
@@ skipping 23 matching lines @@
   // won't associate the new version with a provider being destroyed.
   document_url_ = GURL();
   if (controlling_version_)
     controlling_version_->RemoveControllee(this);
   if (active_version_)
     active_version_->RemovePotentialControllee(this);
   if (waiting_version_)
     waiting_version_->RemovePotentialControllee(this);
   if (installing_version_)
     installing_version_->RemovePotentialControllee(this);
+  if (associated_registration_)
+    associated_registration_->RemoveListener(this);
+}
+
+void ServiceWorkerProviderHost::OnVersionAttributesChanged(
+    ServiceWorkerRegistration* registration,
+    ChangedVersionAttributesMask changed_mask,
+    const ServiceWorkerRegistrationInfo& info) {
+  if (changed_mask.installing_changed())
+    SetInstallingVersion(registration->installing_version());
+  if (changed_mask.waiting_changed())
+    SetWaitingVersion(registration->waiting_version());
+  if (changed_mask.active_changed())
+    SetActiveVersion(registration->active_version());
 }
 
 void ServiceWorkerProviderHost::SetDocumentUrl(const GURL& url) {
   DCHECK(!url.has_ref());
   document_url_ = url;
 }
 
 void ServiceWorkerProviderHost::SetControllerVersion(
     ServiceWorkerVersion* version) {
   DCHECK(CanAssociateVersion(version));
@@ skipping 140 matching lines @@
   else if (waiting_version_)
     already_associated_version = waiting_version_;
   else if (installing_version_)
     already_associated_version = installing_version_;
 
   return !already_associated_version ||
          already_associated_version->registration_id() ==
               version->registration_id();
 }
 
+void ServiceWorkerProviderHost::AssociateRegistration(
+    ServiceWorkerRegistration* registration) {
+  DCHECK(registration);
+  if (!context_ || associated_registration_)

[falken, 2014/08/05 02:41:28]

nit: Since AssociateRegistration only takes effect one time, the name is a bit
misleading. The code might be more clear if you add a CanAssociateRegistration()
and have SetRegistration DCHECK it, like the Set*Version functions.

[nhiroki, 2014/08/05 15:51:12]

Done.

+    return;
+  associated_registration_ = registration;
+  registration->AddListener(this);
+}
+
 void ServiceWorkerProviderHost::PostMessage(
     const base::string16& message,
     const std::vector<int>& sent_message_port_ids) {
   if (!dispatcher_host_)
     return;  // Could be NULL in some tests.
 
   std::vector<int> new_routing_ids;
   dispatcher_host_->message_port_message_filter()->
       UpdateMessagePortsWithNewRoutes(sent_message_port_ids,
                                       &new_routing_ids);
@@ skipping 17 matching lines @@
     dispatcher_host_->RegisterServiceWorkerHandle(handle.Pass());
   }
   return info;
 }
 
 bool ServiceWorkerProviderHost::IsContextAlive() {
   return context_ != NULL;
 }
 
 }  // namespace content