Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417043004: Run SWTBot tests along with EggPlant. (Closed)

Created:
6 years, 4 months ago by messick
Modified:
6 years, 4 months ago
Reviewers:
ricow1, Bill Hesse
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Run SWTBot tests along with EggPlant. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=38834

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M tools/bots/functional_testing.py View 1 4 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
messick
6 years, 4 months ago (2014-07-31 22:55:51 UTC) #1
ricow1
lgtm https://codereview.chromium.org/417043004/diff/1/tools/bots/functional_testing.py File tools/bots/functional_testing.py (right): https://codereview.chromium.org/417043004/diff/1/tools/bots/functional_testing.py#newcode28 tools/bots/functional_testing.py:28: def IsWindows(): this will not work on windows?
6 years, 4 months ago (2014-08-01 11:05:05 UTC) #2
messick
https://codereview.chromium.org/417043004/diff/1/tools/bots/functional_testing.py File tools/bots/functional_testing.py (right): https://codereview.chromium.org/417043004/diff/1/tools/bots/functional_testing.py#newcode28 tools/bots/functional_testing.py:28: def IsWindows(): On 2014/08/01 11:05:05, ricow1 wrote: > this ...
6 years, 4 months ago (2014-08-01 14:44:44 UTC) #3
messick
6 years, 4 months ago (2014-08-01 15:08:03 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r38834 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698