sdk/lib/_internal/compiler/implementation/cps_ir/redundant_phi.dart - Issue 417043003: Implement shrinking reductions in CPS IR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/cps_ir/redundant_phi.dart

Issue 417043003: Implement shrinking reductions in CPS IR (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments, fixed several bugs exposed by later commits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/cps_ir/optimizers.dart ('k') | sdk/lib/_internal/compiler/implementation/cps_ir/shrinking_reductions.dart » ('j') | sdk/lib/_internal/compiler/implementation/cps_ir/shrinking_reductions.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/cps_ir/redundant_phi.dart

diff --git a/sdk/lib/_internal/compiler/implementation/cps_ir/redundant_phi.dart b/sdk/lib/_internal/compiler/implementation/cps_ir/redundant_phi.dart

index bff4124b42fe4528457ff904ff7dbef94567f1ed..1ce73a5d6a768a7afe2c148fa5ef3aef63345aef 100644

--- a/sdk/lib/_internal/compiler/implementation/cps_ir/redundant_phi.dart

+++ b/sdk/lib/_internal/compiler/implementation/cps_ir/redundant_phi.dart

@@ -12,7 +12,7 @@ part of dart2js.optimizers;

/// (except for feedback). Redundant parameters are removed from the

/// continuation signature, all invocations, and replaced within the

/// continuation body.

-class RedundantPhiEliminator extends RecursiveVisitor {

+class RedundantPhiEliminator extends RecursiveVisitor implements Pass {

final Map<Continuation, List<InvokeContinuation>> cont2invokes =

<Continuation, List<InvokeContinuation>>{};

// For each reference r used in a continuation invocation i, stores the