Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417043002: Modifying PrintingConrollerFactory to accept context instead of Activity. (Closed)

Created:
6 years, 5 months ago by Shrikant Kelkar
Modified:
6 years, 5 months ago
Reviewers:
Ted C, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Modifying PrintingConrollerFactory to accept context instead of Activity. BUG=380313 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/printing/PrintingControllerFactory.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Shrikant Kelkar
6 years, 5 months ago (2014-07-25 00:05:29 UTC) #1
gone
lgtm lgt
6 years, 5 months ago (2014-07-25 00:06:09 UTC) #2
Shrikant Kelkar
The CQ bit was checked by shrikant@chromium.org
6 years, 5 months ago (2014-07-25 00:06:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/417043002/1
6 years, 5 months ago (2014-07-25 00:11:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 02:27:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 02:44:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82278)
6 years, 5 months ago (2014-07-25 02:44:18 UTC) #7
Shrikant Kelkar
+tedchoc for OWNERS
6 years, 5 months ago (2014-07-25 04:13:02 UTC) #8
Ted C
lgtm
6 years, 5 months ago (2014-07-25 23:11:29 UTC) #9
Shrikant Kelkar
The CQ bit was checked by shrikant@chromium.org
6 years, 5 months ago (2014-07-25 23:12:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/417043002/1
6 years, 5 months ago (2014-07-25 23:13:37 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 23:43:37 UTC) #12
Message was sent while issue was closed. 
Change committed as 285723

Powered by Google App Engine
This is Rietveld 408576698