Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 41703005: Revert "Trim more dead code from webkit/support/" (Closed)

Created:
7 years, 1 month ago by ojan
Modified:
7 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert "Trim more dead code from webkit/support/" This reverts r230794. Speculative revert to fix the Windows Debug webkit_unit_tests hang. TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -4 lines) Patch
M content/test/test_webkit_platform_support.h View 5 chunks +11 lines, -2 lines 0 comments Download
M content/test/test_webkit_platform_support.cc View 5 chunks +90 lines, -0 lines 0 comments Download
M content/test/webkit_support.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/DEPS View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ojan
Committed patchset #1 manually as r230896 (presubmit successful).
7 years, 1 month ago (2013-10-25 01:19:26 UTC) #1
ojan
Yup. This was it. See http://chromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/1994/steps/webkit_unit_tests/logs/stdio for an example of the failure. On Thu, Oct ...
7 years, 1 month ago (2013-10-25 02:01:15 UTC) #2
jamesr
7 years, 1 month ago (2013-10-25 02:06:44 UTC) #3
OK, thanks for reverting. I'll test on my windows box before attempting to
land again.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698