Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/ninja_script_target_writer.cc

Issue 41703002: Fix GN unit tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/function_exec_script.cc ('K') | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | tools/gn/ninja_script_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_script_target_writer.cc
diff --git a/tools/gn/ninja_script_target_writer.cc b/tools/gn/ninja_script_target_writer.cc
index b36297667a8a0859663a1d5237e4c191e204108c..5dd80953bb473c15b80cb413c8533d86420ba510 100644
--- a/tools/gn/ninja_script_target_writer.cc
+++ b/tools/gn/ninja_script_target_writer.cc
@@ -75,7 +75,11 @@ std::string NinjaScriptTargetWriter::WriteRuleDefinition(
out_ << "rule " << custom_rule_name << std::endl;
out_ << " command = ";
path_output_.WriteFile(out_, settings_->build_settings()->python_path());
- out_ << " gyp-win-tool action-wrapper $arch " << rspfile << std::endl;
+ // TODO(brettw) this hardcodes "environment.x86" which is something that
+ // the Chrome Windows toolchain writes. We should have a way to invoke
+ // python without requiring this gyp_win_tool thing.
+ out_ << " gyp-win-tool action-wrapper environment.x86 " << rspfile
+ << std::endl;
out_ << " description = CUSTOM " << target_label << std::endl;
out_ << " restat = 1" << std::endl;
out_ << " rspfile = " << rspfile << std::endl;
« tools/gn/function_exec_script.cc ('K') | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | tools/gn/ninja_script_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698