linux: Force full hinting when antialiasing is disabled.

linux: Force full hinting when antialiasing is disabled.

Make the Linux implementation of FontRenderParams force full
hinting (along with disabling subpixel rendering and
positioning) when antialiasing is disabled. Cairo also
forces full hinting in this case.

BUG=396239
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285462

[msw, 2014-07-24 22:25:44]

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
File ui/gfx/font_render_params_linux.cc (right):

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux.cc:132: // Cairo forces full hinting when
antialiasing is disabled since anything
nit: "disabled, since"

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
File ui/gfx/font_render_params_linux_unittest.cc (right):

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux_unittest.cc:166:
CreateFontconfigEditStanza("antialias", "bool", "true") +
nit: remove the antialias setting and checks below, now that this property is
irrelevant to the test.

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux_unittest.cc:173:
CreateFontconfigEditStanza("hinting", "bool", "false") +
optional nit: continue disabling hinting for italic, as before, and disable
subpixel for bold to reduce the volume of changes here.

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux_unittest.cc:268: // Full hinting should be
forced.
optional nit: add "See the comment in GetFontRenderParams for more information."

[Daniel Erat, 2014-07-24 22:52:01]

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
File ui/gfx/font_render_params_linux.cc (right):

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux.cc:132: // Cairo forces full hinting when
antialiasing is disabled since anything
On 2014/07/24 22:25:43, msw wrote:
> nit: "disabled, since"

arguable but done :-P

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
File ui/gfx/font_render_params_linux_unittest.cc (right):

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux_unittest.cc:166:
CreateFontconfigEditStanza("antialias", "bool", "true") +
On 2014/07/24 22:25:43, msw wrote:
> nit: remove the antialias setting and checks below, now that this property is
> irrelevant to the test.

i'll remove the checks, but i believe that setting this is actually needed since
it doesn't default to true in fontconfig (unlike most other boolean properties).

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux_unittest.cc:173:
CreateFontconfigEditStanza("hinting", "bool", "false") +
On 2014/07/24 22:25:43, msw wrote:
> optional nit: continue disabling hinting for italic, as before, and disable
> subpixel for bold to reduce the volume of changes here.

Done.

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux_unittest.cc:268: // Full hinting should be
forced.
On 2014/07/24 22:25:44, msw wrote:
> optional nit: add "See the comment in GetFontRenderParams for more
information."

Done.

[msw, 2014-07-24 22:58:26]

lgtm with a nit

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
File ui/gfx/font_render_params_linux_unittest.cc (right):

https://codereview.chromium.org/417003002/diff/1/ui/gfx/font_render_params_li...
ui/gfx/font_render_params_linux_unittest.cc:166:
CreateFontconfigEditStanza("antialias", "bool", "true") +
On 2014/07/24 22:52:01, Daniel Erat wrote:
> On 2014/07/24 22:25:43, msw wrote:
> > nit: remove the antialias setting and checks below, now that this property
is
> > irrelevant to the test.
> 
> i'll remove the checks, but i believe that setting this is actually needed
since
> it doesn't default to true in fontconfig (unlike most other boolean
properties).

Acknowledged.

https://codereview.chromium.org/417003002/diff/20001/ui/gfx/font_render_param...
File ui/gfx/font_render_params_linux_unittest.cc (right):

https://codereview.chromium.org/417003002/diff/20001/ui/gfx/font_render_param...
ui/gfx/font_render_params_linux_unittest.cc:161: // Load a config that disables
hinting for bold text and disables subpixel
nit: "subpixel rendering for bold" and "hinting for italic".

[Daniel Erat, 2014-07-24 23:00:07]

https://codereview.chromium.org/417003002/diff/20001/ui/gfx/font_render_param...
File ui/gfx/font_render_params_linux_unittest.cc (right):

https://codereview.chromium.org/417003002/diff/20001/ui/gfx/font_render_param...
ui/gfx/font_render_params_linux_unittest.cc:161: // Load a config that disables
hinting for bold text and disables subpixel
On 2014/07/24 22:58:26, msw wrote:
> nit: "subpixel rendering for bold" and "hinting for italic".

sorry. :-( done

[Daniel Erat, 2014-07-25 00:40:16]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-07-25 00:44:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/derat@chromium.org/417003002/40001

[commit-bot: I haz the power, 2014-07-25 02:39:26]

Change committed as 285462