Issue 417002: GTK bookmark manager polish....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 417002: GTK bookmark manager polish.... (Closed)

Created:
11 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK bookmark manager polish. 1. on right tree view, deselect everything when user presses below lowest row. This is not native gtktreeview behavior, but it is used in windows and by nautilus via libegg, so it matches user expectations. 2. allow default left click handler to run on right tree view. This allows a left click below the lowest row to cause the tree view pane to take focus. 3. continue blocking empty drags. BUG=27869, 27872 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32585

Patch Set 1 #

Patch Set 2 : typo #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1	3 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

(erg LGed via email)

Expand Messages | Collapse Messages