Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: content/child/webcrypto/status.h

Issue 416993009: [webcrypto] JWK: Reject keys with non-minimal bigintegers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: improve a test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/status.h
diff --git a/content/child/webcrypto/status.h b/content/child/webcrypto/status.h
index d0f2b4a82efd8555a058effe5c787f6d1ab3e0d1..a9ff4373d8b20609c887258088612715ee310503 100644
--- a/content/child/webcrypto/status.h
+++ b/content/child/webcrypto/status.h
@@ -103,9 +103,13 @@ class CONTENT_EXPORT Status {
// given that is an error.
static Status ErrorJwkIncorrectKeyLength();
- // The JWK was for an RSA private key but only partially provided the optional
- // parameters (p, q, dq, dq, qi).
- static Status ErrorJwkIncompleteOptionalRsaPrivateKey();
+ // The JWK property |property| is supposed to represent a big-endian unsigned
+ // integer, however was the empty string.
+ static Status ErrorJwkEmptyBigInteger(const std::string& property);
+
+ // The big-endian unsigned integer |property| contained leading zeros. This
+ // violates the JWA requirement that such octet strings be minimal.
+ static Status ErrorJwkBigIntegerHasLeadingZero(const std::string& property);
// ------------------------------------
// Other errors

Powered by Google App Engine
This is Rietveld 408576698