Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 416993006: Add IPv4/IPv6 counters to UMA even when count is 0. (Closed)

Created:
6 years, 5 months ago by Mallinath (Gone from Chromium)
Modified:
6 years, 5 months ago
Reviewers:
jiayl
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Add IPv4/IPv6 counters to UMA even when count is 0. R=jiayl@chromium.org TBR=sergeyu@chromium.org BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285630

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M content/renderer/p2p/ipc_network_manager.cc View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mallinath (Gone from Chromium)
PTAL
6 years, 5 months ago (2014-07-25 18:17:18 UTC) #1
jiayl
On 2014/07/25 18:17:18, mallinath2 wrote: > PTAL lgtm
6 years, 5 months ago (2014-07-25 18:21:36 UTC) #2
Mallinath (Gone from Chromium)
The CQ bit was checked by mallinath@chromium.org
6 years, 5 months ago (2014-07-25 18:22:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/416993006/1
6 years, 5 months ago (2014-07-25 18:23:12 UTC) #4
Mallinath (Gone from Chromium)
6 years, 5 months ago (2014-07-25 18:45:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r285630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698