Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 416993005: Fix microbench JSON schema (Closed)

Created:
6 years, 5 months ago by kelvinly
Modified:
6 years, 5 months ago
Reviewers:
jcgregorio, benchen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M perf/server/microbench.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kelvinly
Making the schema match the actual JSON. Looks like there was a change in builder_name_schema.py ...
6 years, 5 months ago (2014-07-25 14:37:29 UTC) #1
benchen
LGTM. Note that the borgcron ingestion is using the schema copy in skia main repo. ...
6 years, 5 months ago (2014-07-25 15:07:50 UTC) #2
kelvinly
On 2014/07/25 15:07:50, benchen wrote: > LGTM. Note that the borgcron ingestion is using the ...
6 years, 5 months ago (2014-07-25 15:10:12 UTC) #3
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 5 months ago (2014-07-25 15:11:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/416993005/1
6 years, 5 months ago (2014-07-25 15:11:36 UTC) #5
commit-bot: I haz the power
Change committed as 81f4fc9f64e43b31909a4eaa9327712c0374477a
6 years, 5 months ago (2014-07-25 15:11:45 UTC) #6
benchen
We should only keep one copy - so probably change the borgcron ingestor to read ...
6 years, 5 months ago (2014-07-25 15:11:57 UTC) #7
kelvinly
6 years, 5 months ago (2014-07-25 15:13:36 UTC) #8
Message was sent while issue was closed.
On 2014/07/25 15:11:57, benchen wrote:
> We should only keep one copy - so probably change the borgcron ingestor to
read
> the buildbot one, and delete the skia main repo one?

SGTM

Powered by Google App Engine
This is Rietveld 408576698