QUIC - Track the reason for sending InchoateClientHello in UMA

QUIC - Track the reason for sending InchoateClientHello in UMA
histogram.

Possible reasons are: no/empty server config, expired server config,
invalid server config and corrupted server config.

R=rch@chromium.org, asvitkine@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285765

[ramant (doing other things), 2014-07-25 04:32:15]

We have seen that server is receiving lot of InchoateClientHello messages (in
reject reason histogram). 

Track the reason for sending InchoateClientHello (is it expired server config or
empty server config or invalid/corrupted server config) per conversations with
avd and rch.

thanks
raman

[jar (doing other things), 2014-07-25 16:04:16]

lgtm

[Alexei Svitkine (slow), 2014-07-25 16:24:13]

lgtm

[ramant (doing other things), 2014-07-25 18:46:05]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-07-25 18:47:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/416983005/20001

[commit-bot: I haz the power, 2014-07-25 20:48:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-26 18:06:22]

Change committed as 285765

[wtc, 2014-07-29 01:29:06]

Patch set 2 LGTM.

https://codereview.chromium.org/416983005/diff/20001/net/quic/crypto/quic_cry...
File net/quic/crypto/quic_crypto_client_config.cc (right):

https://codereview.chromium.org/416983005/diff/20001/net/quic/crypto/quic_cry...
net/quic/crypto/quic_crypto_client_config.cc:90: if (scfg->GetUint64(kEXPY,
&expiry_seconds) != QUIC_NO_ERROR ||

Nit: scfg->GetUint64(kEXPY, &expiry_seconds) != QUIC_NO_ERROR is a separate
error condition. It means the server config has an absent or invalid kEXPY
value.

[ramant (doing other things), 2014-07-29 23:52:32]

https://codereview.chromium.org/416983005/diff/20001/net/quic/crypto/quic_cry...
File net/quic/crypto/quic_crypto_client_config.cc (right):

https://codereview.chromium.org/416983005/diff/20001/net/quic/crypto/quic_cry...
net/quic/crypto/quic_crypto_client_config.cc:90: if (scfg->GetUint64(kEXPY,
&expiry_seconds) != QUIC_NO_ERROR ||
On 2014/07/29 01:29:06, wtc wrote:
> 
> Nit: scfg->GetUint64(kEXPY, &expiry_seconds) != QUIC_NO_ERROR is a separate
> error condition. It means the server config has an absent or invalid kEXPY
> value.

Thanks Wan-Teh. Fixed it in https://codereview.chromium.org/431483002/

Done.