Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: Source/core/dom/ElementTraversal.h

Issue 416933002: Regression(r178540): Traversal<*Element>::lastWithin() is incorrect (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix build error Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Appl e Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Appl e Inc. All rights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * Copyright (C) 2014 Samsung Electronics. All rights reserved. 7 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 Node* node = current.firstChild(); 213 Node* node = current.firstChild();
214 while (node && !isElementOfType<const ElementType>(*node)) 214 while (node && !isElementOfType<const ElementType>(*node))
215 node = NodeTraversal::next(*node, &current); 215 node = NodeTraversal::next(*node, &current);
216 return toElement<ElementType>(node); 216 return toElement<ElementType>(node);
217 } 217 }
218 218
219 template <class ElementType> 219 template <class ElementType>
220 template <class NodeType> 220 template <class NodeType>
221 inline ElementType* Traversal<ElementType>::lastWithinTemplate(NodeType& current ) 221 inline ElementType* Traversal<ElementType>::lastWithinTemplate(NodeType& current )
222 { 222 {
223 Node* node = current.lastChild(); 223 Node* node = NodeTraversal::lastWithin(current);
224 while (node && !isElementOfType<const ElementType>(*node)) 224 while (node && !isElementOfType<const ElementType>(*node))
225 node = NodeTraversal::previous(node, &current); 225 node = NodeTraversal::previous(*node, &current);
226 return toElement<ElementType>(node); 226 return toElement<ElementType>(node);
227 } 227 }
228 228
229 template <class ElementType> 229 template <class ElementType>
230 template <class NodeType> 230 template <class NodeType>
231 inline ElementType* Traversal<ElementType>::nextTemplate(NodeType& current) 231 inline ElementType* Traversal<ElementType>::nextTemplate(NodeType& current)
232 { 232 {
233 Node* node = NodeTraversal::next(current); 233 Node* node = NodeTraversal::next(current);
234 while (node && !isElementOfType<const ElementType>(*node)) 234 while (node && !isElementOfType<const ElementType>(*node))
235 node = NodeTraversal::next(*node); 235 node = NodeTraversal::next(*node);
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 { 336 {
337 Node* node = current.nextSibling(); 337 Node* node = current.nextSibling();
338 while (node && !isElementOfType<const ElementType>(*node)) 338 while (node && !isElementOfType<const ElementType>(*node))
339 node = node->nextSibling(); 339 node = node->nextSibling();
340 return toElement<ElementType>(node); 340 return toElement<ElementType>(node);
341 } 341 }
342 342
343 } // namespace blink 343 } // namespace blink
344 344
345 #endif 345 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698