Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 416913002: Update Confusing Log Message (Closed)

Created:
6 years, 5 months ago by robliao
Modified:
6 years, 5 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, skare_, rgustafson, sunangel, smaslo
Project:
chromium
Visibility:
Public.

Description

Update Confusing Log Message The chrome.notifications.update will reasonably not update notifications that do not exist. Previously, the console would log that the update failed to occur since there was no update. This gives the wrong impression of an error. This delta relaxes the wording to "not updated". BUG=396881 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/google_now/cards.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
robliao
xiyuan: Please provide owner approval for this CL. Thanks!
6 years, 5 months ago (2014-07-24 17:26:51 UTC) #1
xiyuan
lgtm
6 years, 5 months ago (2014-07-25 16:35:47 UTC) #2
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 5 months ago (2014-07-25 17:09:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/416913002/1
6 years, 5 months ago (2014-07-25 17:10:41 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 19:56:42 UTC) #5
Message was sent while issue was closed.
Change committed as 285649

Powered by Google App Engine
This is Rietveld 408576698