Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 416893002: ozone: demo: Add software support & use message loop (Closed)

Created:
6 years, 5 months ago by spang
Modified:
6 years, 5 months ago
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

ozone: demo: Add software support & use message loop This sample app is useful for testing but doesn't have software support. Add it and use it when we can't initalize GL. Also, fix the app to not block the message loop indefinitely. We can render on a task and let other work (event processing) continue. BUG=none TEST=ozone_demo on egltest, caca NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285342

Patch Set 1 #

Total comments: 2

Patch Set 2 : add some comments related to message loop #

Patch Set 3 : capitalize log messages #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -104 lines) Patch
D ui/ozone/demo/egl_demo.cc View 1 chunk +0 lines, -101 lines 0 comments Download
A ui/ozone/demo/ozone_demo.cc View 1 2 1 chunk +215 lines, -0 lines 0 comments Download
M ui/ozone/demo/ozone_demos.gyp View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
spang
6 years, 5 months ago (2014-07-24 16:57:49 UTC) #1
spang
should probably use better vsync technology
6 years, 5 months ago (2014-07-24 17:00:51 UTC) #2
dnicoara
lgtm https://codereview.chromium.org/416893002/diff/1/ui/ozone/demo/ozone_demo.cc File ui/ozone/demo/ozone_demo.cc (right): https://codereview.chromium.org/416893002/diff/1/ui/ozone/demo/ozone_demo.cc#newcode55 ui/ozone/demo/ozone_demo.cc:55: LOG(ERROR) << "failed to create drawing surface"; nit: ...
6 years, 5 months ago (2014-07-24 17:12:04 UTC) #3
alexst (slow to review)
lgtm, modulo comments in main()
6 years, 5 months ago (2014-07-24 17:21:22 UTC) #4
spang
https://codereview.chromium.org/416893002/diff/1/ui/ozone/demo/ozone_demo.cc File ui/ozone/demo/ozone_demo.cc (right): https://codereview.chromium.org/416893002/diff/1/ui/ozone/demo/ozone_demo.cc#newcode55 ui/ozone/demo/ozone_demo.cc:55: LOG(ERROR) << "failed to create drawing surface"; On 2014/07/24 ...
6 years, 5 months ago (2014-07-24 17:39:14 UTC) #5
spang
The CQ bit was checked by spang@chromium.org
6 years, 5 months ago (2014-07-24 18:44:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/416893002/60001
6 years, 5 months ago (2014-07-24 18:46:24 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 18:48:47 UTC) #8
Message was sent while issue was closed.
Change committed as 285342

Powered by Google App Engine
This is Rietveld 408576698