Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: build/common.gypi

Issue 416863002: Make it possible to generate static and dynamic CLD2 libraries in one build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add all_dependent_settings for CLD2_DYNAMIC_MODE Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/cld_2/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ef1ce1539735ae4c30880c0bc390bc5f4b2e8448..dab904a4f5d131fabc53e3e778a729f956fc7065 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2764,18 +2764,13 @@
# chrome://translate-internals
'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'],
}],
- ['cld2_data_source=="static"', {
+ ['cld_version==2 and cld2_data_source=="static"', {
'defines': ['CLD_DATA_FROM_STATIC'],
- }, {
- # CLD2 headers use this #define to control the visibility of dynamic
- # mode functions. We use these functions, so we must define here for
- # our #includes to work right.
- 'defines': ['CLD2_DYNAMIC_MODE'],
}],
- ['cld2_data_source=="standalone"', {
+ ['cld_version==2 and cld2_data_source=="standalone"', {
'defines': ['CLD_DATA_FROM_STANDALONE'],
}],
- ['cld2_data_source=="component"', {
+ ['cld_version==2 and cld2_data_source=="component"', {
'defines': ['CLD_DATA_FROM_COMPONENT'],
}],
['enable_printing==1', {
« no previous file with comments | « no previous file | third_party/cld_2/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698