Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 416863002: Make it possible to generate static and dynamic CLD2 libraries in one build. (Closed)

Created:
6 years, 5 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make it possible to generate static and dynamic CLD2 libraries in one build. This is necessary to allow building multiple targets with conflicting requirements, such as chrome_shell (needing a statically-linked CLD2) at the same time as the APK for Android (using, e.g., the "component" CLD2 data source). For more information and background, refer to the linked bug. This change should be a no-op in all current build configurations, but moves closer to enabling the behavior described above. BUG=367239 TBR=toyoshim NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285289

Patch Set 1 #

Patch Set 2 : Add all_dependent_settings for CLD2_DYNAMIC_MODE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -280 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/cld_2/BUILD.gn View 1 2 chunks +117 lines, -104 lines 0 comments Download
M third_party/cld_2/cld_2.gyp View 2 chunks +118 lines, -168 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Andrew Hayden (chromium.org)
PTAL. I'll TBR if the bots can confirm correct functionality, as this is purely a ...
6 years, 5 months ago (2014-07-24 13:30:57 UTC) #1
Andrew Hayden (chromium.org)
I've uploaded a second patchset that fixes the all_dependent_settings for GN non-static builds. I manually ...
6 years, 5 months ago (2014-07-24 14:17:55 UTC) #2
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 5 months ago (2014-07-24 14:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/416863002/20001
6 years, 5 months ago (2014-07-24 14:35:20 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 15:58:42 UTC) #5
Message was sent while issue was closed.
Change committed as 285289

Powered by Google App Engine
This is Rietveld 408576698