Issue 416843002: DevTools: Send async stack trace with Network.Initiator.

Issue 416843002: DevTools: Send async stack trace with Network.Initiator. (Closed)

Created:
6 years, 5 months ago by aandrey

Modified:
6 years, 4 months ago

Reviewers:
apavlov, eustas, vsevik, yurys, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Send async stack trace with Network.Initiator. Send async stack trace for Network.Initiator to frontend, and show it in console and popover in the Network panel. BUG=169721 R=eustas, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179109

Patch Set 1 : #

Total comments: 2

Patch Set 2 : addressed #

Patch Set 3 : rebased #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -41 lines)			Patch
A +	LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator.html	View		3 chunks	+10 lines, -24 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-expected.txt	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorResourceAgent.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/console/ConsoleViewMessage.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/network/NetworkPanel.js	View	1 2	1 chunk	+32 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/networkLogView.css	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/sdk/ConsoleModel.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sources/CallStackSidebarPane.js	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/devtools/front_end/ui/UIUtils.js	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	Source/devtools/protocol.json	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

eustas

lgtm https://codereview.chromium.org/416843002/diff/20001/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/416843002/diff/20001/Source/devtools/front_end/network/NetworkPanel.js#newcode1036 Source/devtools/front_end/network/NetworkPanel.js:1036: for (; asyncStackTrace; asyncStackTrace = asyncStackTrace.asyncStackTrace) { may ...

6 years, 5 months ago (2014-07-24 13:47:02 UTC) #2

aandrey

https://codereview.chromium.org/416843002/diff/20001/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/416843002/diff/20001/Source/devtools/front_end/network/NetworkPanel.js#newcode1036 Source/devtools/front_end/network/NetworkPanel.js:1036: for (; asyncStackTrace; asyncStackTrace = asyncStackTrace.asyncStackTrace) { On 2014/07/24 ...

6 years, 5 months ago (2014-07-24 13:51:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/416843002/60001

6 years, 4 months ago (2014-07-29 08:04:24 UTC) #7

Message was sent while issue was closed.

Change committed as 179109

Expand Messages | Collapse Messages