Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 416833005: Update gyp to support SSSE3/SSE4 compile checks. (Closed)

Created:
6 years, 5 months ago by djsollen
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update gyp to support SSSE3/SSE4 compile checks. Additional compile time checks are being added to Skia and since MSVS compilers don't support querying the compiler for support we must manually set the values. This mirrors what has already been done in the main Skia repo. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M skia/skia_library_opts.gyp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
djsollen
6 years, 5 months ago (2014-07-24 15:06:20 UTC) #1
bungeman-chromium
lgtm
6 years, 5 months ago (2014-07-24 15:17:49 UTC) #2
bungeman-skia
lgtm
6 years, 5 months ago (2014-07-24 15:18:19 UTC) #3
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 5 months ago (2014-07-24 15:19:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djsollen@google.com/416833005/1
6 years, 5 months ago (2014-07-24 15:20:47 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 20:31:02 UTC) #6
Message was sent while issue was closed.
Change committed as 285358

Powered by Google App Engine
This is Rietveld 408576698