This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called

net/socket/ssl_client_socket_openssl.h

Index: net/socket/ssl_client_socket_openssl.h
diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h
index ac65710bd1e683c023994fd7aebb914b1605ae50..80895910f69c269da3f474745d0531a87be08dee 100644
--- a/net/socket/ssl_client_socket_openssl.h
+++ b/net/socket/ssl_client_socket_openssl.h
@@ -106,6 +106,9 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
   friend class SSLClientSocket;
   friend class SSLContext;
 
+  // Callback that is run by OpenSSL when a session's handshake has finished.
+  static void OnSessionFinishedCallback(const SSL* ssl, int result, int unused);

[wtc, 2014/08/07 02:10:12]

This callback should be named "InfoCallback", and the comment should be updated
accordingly. The info callback is called not just when the handshake is
finished.

+
   int Init();
   void DoReadCallback(int result);
   void DoWriteCallback(int result);
@@ -168,6 +171,8 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
                           const char *argp, int argi, long argl,
                           long retvalue);
 
+  void CheckIfSessionFinished();

[wtc, 2014/08/07 02:10:12]

SessionFinished => HandshakeFinished

+
   bool transport_send_busy_;
   bool transport_recv_busy_;
 
@@ -268,6 +273,8 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
   std::string channel_id_cert_;
   // True if channel ID extension was negotiated.
   bool channel_id_xtn_negotiated_;
+  // True if OnSessionFinishedCallback has been run.

[wtc, 2014/08/07 02:10:12]

This comment is wrong. It should say something like:

  // True if OnSessionFinishedCallback has been run with
result=SSL_CB_HANDSHAKE_DONE.

The data member should be renamed accordingly.

+  bool ran_session_finished_callback_;

[wtc, 2014/08/07 02:10:12]

Change "session finished" to "handshake finished" in all comments and identifier
names. "session finished" doesn't make sense.

   // The request handle for |channel_id_service_|.
   ChannelIDService::RequestHandle channel_id_request_handle_;
   BoundNetLog net_log_;