This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called

net/test/spawned_test_server/base_test_server.cc

Index: net/test/spawned_test_server/base_test_server.cc
diff --git a/net/test/spawned_test_server/base_test_server.cc b/net/test/spawned_test_server/base_test_server.cc
index 26608c63bbd561d638a96a81b6d99afb2bd37acd..b9286ad9562e589973501da86ae04cc8becf7fca 100644
--- a/net/test/spawned_test_server/base_test_server.cc
+++ b/net/test/spawned_test_server/base_test_server.cc
@@ -101,7 +101,9 @@ BaseTestServer::SSLOptions::SSLOptions()
       tls_intolerance_type(TLS_INTOLERANCE_ALERT),
       fallback_scsv_enabled(false),
       staple_ocsp_response(false),
-      enable_npn(false) {}
+      enable_npn(false),
+      disable_session_cache(false) {
+}
 
 BaseTestServer::SSLOptions::SSLOptions(
     BaseTestServer::SSLOptions::ServerCertificate cert)
@@ -116,7 +118,9 @@ BaseTestServer::SSLOptions::SSLOptions(
       tls_intolerance_type(TLS_INTOLERANCE_ALERT),
       fallback_scsv_enabled(false),
       staple_ocsp_response(false),
-      enable_npn(false) {}
+      enable_npn(false),
+      disable_session_cache(false) {
+}
 
 BaseTestServer::SSLOptions::~SSLOptions() {}
 
@@ -474,6 +478,8 @@ bool BaseTestServer::GenerateArguments(base::DictionaryValue* arguments) const {
       arguments->Set("staple-ocsp-response", base::Value::CreateNullValue());
     if (ssl_options_.enable_npn)
       arguments->Set("enable-npn", base::Value::CreateNullValue());
+    if (ssl_options_.disable_session_cache)
+      arguments->Set("none-session-cache", base::Value::CreateNullValue());

[Ryan Sleevi, 2014/08/07 00:27:41]

BUG

[mshelley, 2014/08/07 00:55:05]

Done.

   }
 
   return GenerateAdditionalArguments(arguments);