net/socket/ssl_session_cache_openssl.h - Issue 416683002: This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_session_cache_openssl.h

Issue 416683002: This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r2

Patch Set: Removed session to callback map from SSLSessionCallback, added unittest Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/socket/ssl_client_socket_openssl.cc ('K') | « net/socket/ssl_client_socket_unittest.cc ('k') | net/socket/ssl_session_cache_openssl.cc » ('j') | net/test/spawned_test_server/base_test_server.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/ssl_session_cache_openssl.h

diff --git a/net/socket/ssl_session_cache_openssl.h b/net/socket/ssl_session_cache_openssl.h

index 00f93e1949539a9540d444083673c5e6dd321303..8c2ed4fed03428d3298a297d0af2de6c5e2e7822 100644

--- a/net/socket/ssl_session_cache_openssl.h

+++ b/net/socket/ssl_session_cache_openssl.h

@@ -117,13 +117,6 @@ class NET_EXPORT SSLSessionCacheOpenSSL {

// Return true iff a cached session was associated with the given |cache_key|.

bool SSLSessionIsInCache(const std::string& cache_key) const;

- // Informs the cache that it should run a callback when |ssl|'s session is

- // added to the cache.

- void SetSessionAddedCallback(SSL* ssl, const base::Closure& callback);

- // Removes the entry for |ssl| from cache's callback map.

- void RemoveSessionAddedCallback(SSL* ssl);

// Indicates that the SSL session associated with |ssl| is "good" - that is,

// that all associated cryptographic parameters that were negotiated,

// including the peer's certificate, were successfully validated. Because