net/socket/ssl_client_socket_nss.cc - Issue 416683002: This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 416683002: This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r2

Patch Set: Removed session to callback map from SSLSessionCallback, added unittest Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_nss.cc

diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc

index 0237eb522e96f5508ed3e3768ab41c970527df0e..0d3c53d891e98c06de0fcaa0aeac4d286e2b89ab 100644

--- a/net/socket/ssl_client_socket_nss.cc

+++ b/net/socket/ssl_client_socket_nss.cc

@@ -2843,6 +2843,7 @@ void SSLClientSocketNSS::SetHandshakeCompletionCallback(

const base::Closure& callback) {

NOTIMPLEMENTED();

}

void SSLClientSocketNSS::GetSSLCertRequestInfo(

SSLCertRequestInfo* cert_request_info) {

EnterFunction("");

« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.h » ('j') | net/socket/ssl_client_socket_openssl.h » ('J')