This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called

net/test/spawned_test_server/base_test_server.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TEST_SPAWNED_TEST_SERVER_BASE_TEST_SERVER_H_
 #define NET_TEST_SPAWNED_TEST_SERVER_BASE_TEST_SERVER_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 185 matching lines @@
     // TODO(ekasper): replace with valid SCT files for test certs.
     // (Fake) SignedCertificateTimestampList (as a raw binary string) to send in
     // a TLS extension.
     std::string signed_cert_timestamps_tls_ext;
 
     // Whether to staple the OCSP response.
     bool staple_ocsp_response;
 
     // Whether to enable NPN support.
     bool enable_npn;
+
+    // Whether to disable TLS session caching. When session caching is
+    // disabled, the server will generate a new Session ID for every connection.

[wtc, 2014/08/07 20:04:04]

Hmm... "generate a new session ID" is not the behavior we want to test. What we
want to test is that the server returns an empty session ID in ServerHello.

I checked the tlslite/tls_connection.py code. It seems that if 'sessionCache' is
'None', it generates an empty session ID for ServerHello:

        # Create the ServerHello message
        if sessionCache:
            sessionID = getRandomBytes(32)
        else:
            sessionID = bytearray(0)

So I think this comment should be corrected.

+    bool disable_session_cache;
   };
 
   // Pass as the 'host' parameter during construction to server on 127.0.0.1
   static const char kLocalhost[];
 
   // Initialize a TestServer listening on a specific host (IP or hostname).
   BaseTestServer(Type type,  const std::string& host);
 
   // Initialize a TestServer with a specific set of SSLOptions for HTTPS or WSS.
   BaseTestServer(Type type, const SSLOptions& ssl_options);
@@ skipping 102 matching lines @@
   bool ws_basic_auth_;
 
   scoped_ptr<ScopedPortException> allowed_port_;
 
   DISALLOW_COPY_AND_ASSIGN(BaseTestServer);
 };
 
 }  // namespace net
 
 #endif  // NET_TEST_SPAWNED_TEST_SERVER_BASE_TEST_SERVER_H_