Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: net/socket/ssl_client_socket_nss.cc

Issue 416683002: This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r2
Patch Set: Fixed typos & updated flag description Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file includes code SSLClientSocketNSS::DoVerifyCertComplete() derived 5 // This file includes code SSLClientSocketNSS::DoVerifyCertComplete() derived
6 // from AuthCertificateCallback() in 6 // from AuthCertificateCallback() in
7 // mozilla/security/manager/ssl/src/nsNSSCallbacks.cpp. 7 // mozilla/security/manager/ssl/src/nsNSSCallbacks.cpp.
8 8
9 /* ***** BEGIN LICENSE BLOCK ***** 9 /* ***** BEGIN LICENSE BLOCK *****
10 * Version: MPL 1.1/GPL 2.0/LGPL 2.1 10 * Version: MPL 1.1/GPL 2.0/LGPL 2.1
(...skipping 2825 matching lines...) Expand 10 before | Expand all | Expand 10 after
2836 2836
2837 bool SSLClientSocketNSS::InSessionCache() const { 2837 bool SSLClientSocketNSS::InSessionCache() const {
2838 // For now, always return true so that SSLConnectJobs are never held back. 2838 // For now, always return true so that SSLConnectJobs are never held back.
2839 return true; 2839 return true;
2840 } 2840 }
2841 2841
2842 void SSLClientSocketNSS::SetHandshakeCompletionCallback( 2842 void SSLClientSocketNSS::SetHandshakeCompletionCallback(
2843 const base::Closure& callback) { 2843 const base::Closure& callback) {
2844 NOTIMPLEMENTED(); 2844 NOTIMPLEMENTED();
2845 } 2845 }
2846
2846 void SSLClientSocketNSS::GetSSLCertRequestInfo( 2847 void SSLClientSocketNSS::GetSSLCertRequestInfo(
2847 SSLCertRequestInfo* cert_request_info) { 2848 SSLCertRequestInfo* cert_request_info) {
2848 EnterFunction(""); 2849 EnterFunction("");
2849 cert_request_info->host_and_port = host_and_port_; 2850 cert_request_info->host_and_port = host_and_port_;
2850 cert_request_info->cert_authorities = core_->state().cert_authorities; 2851 cert_request_info->cert_authorities = core_->state().cert_authorities;
2851 LeaveFunction(""); 2852 LeaveFunction("");
2852 } 2853 }
2853 2854
2854 int SSLClientSocketNSS::ExportKeyingMaterial(const base::StringPiece& label, 2855 int SSLClientSocketNSS::ExportKeyingMaterial(const base::StringPiece& label,
2855 bool has_context, 2856 bool has_context,
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
3574 scoped_refptr<X509Certificate> 3575 scoped_refptr<X509Certificate>
3575 SSLClientSocketNSS::GetUnverifiedServerCertificateChain() const { 3576 SSLClientSocketNSS::GetUnverifiedServerCertificateChain() const {
3576 return core_->state().server_cert.get(); 3577 return core_->state().server_cert.get();
3577 } 3578 }
3578 3579
3579 ChannelIDService* SSLClientSocketNSS::GetChannelIDService() const { 3580 ChannelIDService* SSLClientSocketNSS::GetChannelIDService() const {
3580 return channel_id_service_; 3581 return channel_id_service_;
3581 } 3582 }
3582 3583
3583 } // namespace net 3584 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.h » ('j') | net/socket/ssl_client_socket_openssl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698