Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: Tools/GardeningServer/ui/ct-results-panel.html

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-results-panel.html
diff --git a/Tools/GardeningServer/ui/ct-results-panel.html b/Tools/GardeningServer/ui/ct-results-panel.html
index 03e479ffc6286f85e7c9cb885e3eebdc202a15a4..bd28525bed0691cd6023a99f32d3de44ed41424f 100644
--- a/Tools/GardeningServer/ui/ct-results-panel.html
+++ b/Tools/GardeningServer/ui/ct-results-panel.html
@@ -50,11 +50,15 @@ found in the LICENSE file.
<template if="{{ failures.length }}">
<core-menu selected="{{ selected }}">
<template repeat="{{ failure in failures }}">
- <paper-item label="{{ failure.testName }}"></paper-item>
+ <template if="{{ failure.testName }}">
+ <paper-item label="{{ failure.testName }}"></paper-item>
+ </template>
</template>
</core-menu>
<div class="results">
- <ct-embedded-flakiness-dashboard test="{{ failures[selected].testName }}"></ct-embedded-flakiness-dashboard>
+ <template if="{{ failures[selected].testName }}">
+ <ct-embedded-flakiness-dashboard test="{{ failures[selected] }}"></ct-embedded-flakiness-dashboard>
+ </template>
<ct-results-by-builder failure="{{ failures[selected] }}"></ct-results-by-builder>
</div>
</template>
« no previous file with comments | « Tools/GardeningServer/ui/ct-results-detail-tests.html ('k') | Tools/GardeningServer/ui/ct-results-panel-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698