Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: Tools/GardeningServer/ui/ct-results-panel-tests.html

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-results-panel.html ('k') | Tools/GardeningServer/ui/ct-test-list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-results-panel-tests.html
diff --git a/Tools/GardeningServer/ui/ct-results-panel-tests.html b/Tools/GardeningServer/ui/ct-results-panel-tests.html
index 3e555cb1edfa10ce60482960ff2b9f75c09e3c23..cdc4e096206b17159b6bc015d46c3c0cf1af04db 100644
--- a/Tools/GardeningServer/ui/ct-results-panel-tests.html
+++ b/Tools/GardeningServer/ui/ct-results-panel-tests.html
@@ -94,7 +94,7 @@ module("ct-results-panel");
asyncTest("empty", 1, function() {
var panel = document.createElement('ct-results-panel');
- Platform.endOfMicrotask(function() {
+ requestAnimationFrame(function() {
var message = panel.shadowRoot.querySelector('.message');
equal(message.textContent, 'No results to display.');
@@ -107,7 +107,7 @@ asyncTest("basic", 8, function() {
panel.failures = kExampleFailures;
- Platform.endOfMicrotask(function() {
+ requestAnimationFrame(function() {
var items = panel.shadowRoot.querySelectorAll('paper-item');
equal(items.length, 3);
equal(items[0].label, 'plugins/gesture-events-scrolled.html');
@@ -120,7 +120,7 @@ asyncTest("basic", 8, function() {
panel.shadowRoot.querySelector('core-menu').selected = 2;
- Platform.endOfMicrotask(function() {
+ requestAnimationFrame(function() {
var results = panel.shadowRoot.querySelectorAll('ct-results-by-builder');
equal(results.length, 1);
equal(results[0].failure, kExampleFailures[2]);
@@ -130,5 +130,36 @@ asyncTest("basic", 8, function() {
});
});
+asyncTest("whole step failed", 4, function() {
+ var panel = document.createElement('ct-results-panel');
+
+ var failure = {
+ testName: null,
+ step: 'foo-step',
+ resultNodesByBuilder: {
+ 'WebKit Win7 (dbg)': {
+ actual: 'UNKNOWN',
+ },
+ },
+ oldestFailingRevision: 123,
+ newestPassingRevision: 124,
+ };
+
+ panel.failures = [failure];
+
+ requestAnimationFrame(function() {
+ var items = panel.shadowRoot.querySelectorAll('paper-item');
+ equal(items.length, 0);
+
+ var results = panel.shadowRoot.querySelectorAll('ct-results-by-builder');
+ equal(results.length, 1);
+ equal(results[0].failure, failure);
+
+ equal(panel.shadowRoot.querySelectorAll('ct-embedded-flakiness-dashboard').length, 0);
+
+ start();
+ });
+});
+
})()
</script>
« no previous file with comments | « Tools/GardeningServer/ui/ct-results-panel.html ('k') | Tools/GardeningServer/ui/ct-test-list.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698