Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1561)

Unified Diff: Tools/GardeningServer/ui/ct-results-by-builder.html

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-results-by-builder.html
diff --git a/Tools/GardeningServer/ui/ct-results-by-builder.html b/Tools/GardeningServer/ui/ct-results-by-builder.html
index e359af790ec11b14b1db1c864ec066eb10a4443d..fcf484e02f94a094e7e66a17553a7af1a7983558 100644
--- a/Tools/GardeningServer/ui/ct-results-by-builder.html
+++ b/Tools/GardeningServer/ui/ct-results-by-builder.html
@@ -16,13 +16,12 @@ found in the LICENSE file.
display: block;
}
</style>
- <paper-tabs selected="{{selected}}">
- <template repeat="{{builder in builders}}">
- <paper-tab>{{builder|displayName}}</paper-tab>
+ <paper-tabs selected="{{ selected }}">
+ <template repeat="{{ builder in builders }}">
+ <paper-tab>{{ builder | displayName }}</paper-tab>
</template>
</paper-tabs>
- <ct-results-detail test="{{failure.testName}}" builder="{{builders[selected]}}"
- result="{{failure.resultNodesByBuilder[builders[selected]].actual}}"></ct-results-detail>
+ <ct-results-detail failure="{{ failure }}" builder="{{ builders[selected] }}"></ct-results-detail>
</template>
<script>
Polymer({
@@ -31,7 +30,7 @@ found in the LICENSE file.
selected: 0,
failureChanged: function() {
- this.builders = Object.getOwnPropertyNames(this.failure.resultNodesByBuilder);
+ this.builders = Object.getOwnPropertyNames(this.failure.resultNodesByBuilder).sort();
this.selected = 0;
},
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-card-tests.html ('k') | Tools/GardeningServer/ui/ct-results-by-builder-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698