Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: Tools/GardeningServer/ui/ct-results-by-builder-tests.html

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-results-by-builder-tests.html
diff --git a/Tools/GardeningServer/ui/ct-results-by-builder-tests.html b/Tools/GardeningServer/ui/ct-results-by-builder-tests.html
index e10463a80f1a95664cd4b40037761e9dccd0fdcd..c7ae083f4d6019aee0fdcbbcd8687bc2f93c3c28 100644
--- a/Tools/GardeningServer/ui/ct-results-by-builder-tests.html
+++ b/Tools/GardeningServer/ui/ct-results-by-builder-tests.html
@@ -12,29 +12,20 @@ found in the LICENSE file.
var kExampleFailure = {
"testName": "inspector/console/console-viewport-selection.html",
"resultNodesByBuilder": {
+ "WebKit Mac10.6 (dbg)": {
+ "actual": "IMAGE",
+ },
"WebKit Linux (dbg)": {
- "expected": "SLOW",
- "is_unexpected": true,
"actual": "TEXT",
- "bugs": ["webkit.org/b/90488"],
- "time": 5.9
},
- "WebKit Mac10.6 (dbg)": {
- "actual": "IMAGE",
- "time": 6.5,
- "bugs": ["webkit.org/b/90488"],
- "is_unexpected": true,
- "expected": "SLOW",
- "has_stderr": true
- }
},
"oldestFailingRevision": 177164,
- "newestPassingRevision": 177165
+ "newestPassingRevision": 177165,
};
module("ct-results-by-builder");
-asyncTest("basic", 11, function() {
+asyncTest("basic", 9, function() {
// FIXME: Remove this override when ct-results-detail is fixed to not use
// results.fetchResultsURLs.
var oldFetchResultsURLs = results.fetchResultsURLs;
@@ -51,9 +42,8 @@ asyncTest("basic", 11, function() {
var detail = resultsByBuilder.shadowRoot.querySelectorAll('ct-results-detail');
equal(detail.length, 1);
- equal(detail[0].test, 'inspector/console/console-viewport-selection.html');
+ equal(detail[0].failure.testName, 'inspector/console/console-viewport-selection.html');
equal(detail[0].builder, 'WebKit Linux (dbg)');
- equal(detail[0].result, 'TEXT');
resultsByBuilder.shadowRoot.querySelector('paper-tabs').selected = 1;
@@ -62,9 +52,8 @@ asyncTest("basic", 11, function() {
var detail = resultsByBuilder.shadowRoot.querySelectorAll('ct-results-detail');
equal(detail.length, 1);
- equal(detail[0].test, 'inspector/console/console-viewport-selection.html');
+ equal(detail[0].failure.testName, 'inspector/console/console-viewport-selection.html');
equal(detail[0].builder, 'WebKit Mac10.6 (dbg)');
- equal(detail[0].result, 'IMAGE');
start();
});
« no previous file with comments | « Tools/GardeningServer/ui/ct-results-by-builder.html ('k') | Tools/GardeningServer/ui/ct-results-detail.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698