Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html - Issue 416673003: Show non-webkit test failures in the failure stream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add files accidentally left out Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html ('k') | Tools/GardeningServer/ui/ct-failing-builders.html » ('j') | Tools/GardeningServer/ui/ct-failure-card.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html

diff --git a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html

index 8aa0f33268bb2cae4fc890a983b270a035343ad2..c4119bbc9bf5d09693f45140cbee0b002d32d757 100644

--- a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html

+++ b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html

@@ -18,14 +18,18 @@ asyncTest("url", 1, function() {

}

try {

- ui.urlForEmbeddedFlakinessDashboard = function(testList) { return "about:blank#" + testList.join(','); }

+ ui.urlForEmbeddedFlakinessDashboard = function(test, step) { return "about:blank#" + test + step; }

var embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');

var testName = "foo/bar.html";

- embeddedFlakinessDashboard.test = testName;

+ var step = "foo_tests";

+ embeddedFlakinessDashboard.test = {

+ testName: testName,

+ step: step,

+ };

requestAnimationFrame(function() {

var iframe = embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');

- equal(iframe.src, ui.urlForEmbeddedFlakinessDashboard([testName]));

+ equal(iframe.src, ui.urlForEmbeddedFlakinessDashboard(testName, step));

reset();

start();

});