Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: Tools/GardeningServer/scripts/ui_unittests.js

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Tools/GardeningServer/scripts/ui.js ('k') | Tools/GardeningServer/ui/ct-builder-grid.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23 * THE POSSIBILITY OF SUCH DAMAGE. 23 * THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 var treestatus = treestatus || {}; 26 (function () {
27 27
28 (function() { 28 module("ui");
29 29
30 // FIXME: Turn this into a model-object class. 30 var flakinessBaseUrl = 'http://test-results.appspot.com/dashboards/flakiness_das hboard.html#';
31 treestatus.urlByName = function(name) {
32 if (name == 'blink')
33 return "http://blink-status.appspot.com/";
34 if (name == 'chromium')
35 return "http://chromium-status.appspot.com/";
36 return null;
37 }
38 31
39 treestatus.fetchTreeStatus = function(statusURL, resultSpan) { 32 test('urlForFlakinessDashboard', 4, function() {
40 return net.json(statusURL).then(function(statusJSON) { 33 equal(ui.urlForFlakinessDashboard('foo', 'bar'),
41 if (statusJSON.can_commit_freely) 34 flakinessBaseUrl + 'tests=foo&testType=bar');
42 resultSpan.textContent = "OPEN"; 35 equal(ui.urlForFlakinessDashboard(['foo', 'baz'], 'bar'),
43 else 36 flakinessBaseUrl + 'tests=foo%2Cbaz&testType=bar');
44 resultSpan.textContent = statusJSON.message + " by " + statusJSON.us ername; 37 equal(ui.urlForFlakinessDashboard('foo', 'webkit_tests'),
45 }); 38 flakinessBaseUrl + 'tests=foo&testType=layout-tests');
46 }; 39 equal(ui.urlForFlakinessDashboard('foo', 'layout-tests'),
40 flakinessBaseUrl + 'tests=foo&testType=layout-tests');
41 });
42
43 test('urlForEmbeddedFlakinessDashboard', 1, function() {
44 equal(ui.urlForEmbeddedFlakinessDashboard('foo', 'bar'),
45 flakinessBaseUrl + 'tests=foo&testType=bar&showChrome=false');
46 });
47 47
48 })(); 48 })();
OLDNEW
« no previous file with comments | « Tools/GardeningServer/scripts/ui.js ('k') | Tools/GardeningServer/ui/ct-builder-grid.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698